[Intel-gfx] [PATCH 28/37] drm/i915: Return a bool not an error code from mode_fixup()

Chris Wilson chris at chris-wilson.co.uk
Wed Mar 10 23:45:15 CET 2010


For kicks, using an error code reversed the return status and so would
cause invalid modes to be used on Ironlake.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e1f4874..aef6141 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2130,7 +2130,7 @@ static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
 	if (HAS_PCH_SPLIT(dev)) {
 		/* FDI link clock is fixed at 2.7G */
 		if (mode->clock * 3 > 27000 * 4)
-			return MODE_CLOCK_HIGH;
+			return false;
 	}
 	return true;
 }
-- 
1.7.0




More information about the Intel-gfx mailing list