[Intel-gfx] [PATCH 15/37] drm/i915: Remove redundant equality check on write_domain

Daniel Vetter daniel at ffwll.ch
Thu Mar 11 10:40:26 CET 2010


On Thu, Mar 11, 2010 at 12:48:30AM +0000, Chris Wilson wrote:
> On Thu, 11 Mar 2010 00:42:37 +0100, Daniel Vetter <daniel at ffwll.ch> wrote:
> > Can't we just completely drop this check? There's only the render cache,
> > after all. Perhaps add a check in the execbuf path to make sure that
> > userspace can't claim to write into the map cache ..
> 
> Yes, we could today. In theory, there may be multiple GPU write domains
> per-device, I suppose...
> -ickle

If that ever happens, I think we also need a new flushing list to track
each write domain separately for efficiency reasons. Then the conditional
would be outside the loop to select which flushing lists to process.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list