[Intel-gfx] [PATCH 02/15] drm/i915: allow lazy emitting of requests

Daniel Vetter daniel.vetter at ffwll.ch
Thu Mar 11 16:58:47 CET 2010

Sometimes (like when flushing in preparation of batchbuffer execution)
we know that we'll emit a request but haven't yet done so. Allow this
case by simply taking the next seqno by default. Ensure that a request
is eventually emitted before waiting for an request by issuing it
in i915_wait_request iff this is not yet done.

Also replace one open-coded version of i915_gem_object_wait_rendering,
to prevent future code-diversion.

Chris Wilson asked me to explain and clarify what this patch does and why.
Here it goes:

Old way of moving objects onto the active list and associating them with a

1. i915_add_request + store the returned seqno somewhere
2. i915_gem_object_move_to_active (with the stored seqno as parameter)

For the current users, this is all fine. But I'd like to associate objects
(and fence regs) with the batchbuffer request deep down in the execbuf
call-chain. I thought about three ways of implementing this.

a) Don't care, just emit request when we need a new seqno. When heavily
pipelining fence reg changes, this would have caused tons of superflous
request (and corresponding irqs).

b) Thread all changed fences, objects, whatever through the execbuf-maze,
so that when we emit a request, we can store the new seqno at all the right

c) Kill that seqno-threading-around business by simply storing the next
seqno, i.e. allow 2. to be done before 1. in the above sequence.

I've decided to implement c) (in this patch). The following patches are
just fall-out that resulted from this small conceptual change.

* We can handle the flushing list processing where we actually emit a flush
  (i915_gem_flush and i915_retire_commands) instead of in i915_add_request.
  The code makes IMHO more sense this way (and i915_add_request looses the
  flush_domains parameter, obviously).

* We can avoid emitting unnecessary requests. IMHO there's no point in
  emitting more than one request per batchbuffer (with or without an
  corresponding irq).

* By enforcing 2. before 1. ordering in the above sequence the seqno
  argument of i915_gem_object_move_to_active is redundant and can be

v2: Now i915_wait_request issues request if it is not yet emitted.
Also introduce i915_gem_next_request_seqno(dev) just in case we ever
need to do some prep work before using a new seqno.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
 drivers/gpu/drm/i915/i915_gem.c |   33 ++++++++++++++++++++++-----------
 1 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 0c6f293..4bacee6 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1485,6 +1485,14 @@ i915_gem_object_put_pages(struct drm_gem_object *obj)
 	obj_priv->pages = NULL;
+static uint32_t
+i915_gem_next_request_seqno(struct drm_device *dev)
+	drm_i915_private_t *dev_priv = dev->dev_private;
+	return dev_priv->mm.next_gem_seqno;
 static void
 i915_gem_object_move_to_active(struct drm_gem_object *obj, uint32_t seqno)
@@ -1497,6 +1505,11 @@ i915_gem_object_move_to_active(struct drm_gem_object *obj, uint32_t seqno)
 		obj_priv->active = 1;
+	/* Take the seqno of the next request if none is given */
+	if (seqno == 0)
+		seqno = i915_gem_next_request_seqno(dev);
 	/* Move from whatever list we were on to the tail of execution. */
@@ -1830,6 +1843,12 @@ i915_do_wait_request(struct drm_device *dev, uint32_t seqno, int interruptible)
 	BUG_ON(seqno == 0);
+	if (seqno == dev_priv->mm.next_gem_seqno) {
+		seqno = i915_add_request(dev, NULL, 0);
+		if (seqno == 0)
+			return -ENOMEM;
+	}
 	if (atomic_read(&dev_priv->mm.wedged))
 		return -EIO;
@@ -2888,7 +2907,6 @@ i915_gem_object_set_to_gtt_domain(struct drm_gem_object *obj, int write)
 i915_gem_object_set_to_display_plane(struct drm_gem_object *obj)
-	struct drm_device *dev = obj->dev;
 	struct drm_i915_gem_object *obj_priv = obj->driver_private;
 	uint32_t old_write_domain, old_read_domains;
 	int ret;
@@ -2898,17 +2916,10 @@ i915_gem_object_set_to_display_plane(struct drm_gem_object *obj)
 		return -EINVAL;
 	/* Wait on any GPU rendering and flushing to occur. */
-	if (obj_priv->active) {
-		DRM_INFO("%s: object %p wait for seqno %08x\n",
-			  __func__, obj, obj_priv->last_rendering_seqno);
-		ret = i915_do_wait_request(dev, obj_priv->last_rendering_seqno, 0);
-		if (ret != 0)
-			return ret;
-	}
+	ret = i915_gem_object_wait_rendering(obj);
+	if (ret != 0)
+		return ret;
 	old_write_domain = obj->write_domain;
 	old_read_domains = obj->read_domains;

More information about the Intel-gfx mailing list