[Intel-gfx] [PATCH] drm/i915: Avoid NULL deref in get_pages() unwind after error.

Eric Anholt eric at anholt.net
Wed Mar 17 21:17:41 CET 2010


On Fri, 12 Mar 2010 19:52:55 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Fixes:
>   http://bugzilla.kernel.org/show_bug.cgi?id=15527
>   NULL pointer dereference in i915_gem_object_save_bit_17_swizzle
> 
> BUG: unable to handle kernel NULL pointer dereference at (null)
> IP: [<f82b5d2b>] i915_gem_object_save_bit_17_swizzle+0x5b/0xc0 [i915]
> Call Trace:
> [<f82aea55>] ? i915_gem_object_put_pages+0x125/0x150 [i915]
> [<f82aeb71>] ? i915_gem_object_get_pages+0xf1/0x110 [i915]
> [<f82b0de8>] ? i915_gem_object_bind_to_gtt+0xb8/0x2a0 [i915]
> [<c02db74d>] ? drm_mm_get_block_generic+0x4d/0x180
> [<f82b11cd>] ? i915_gem_mmap_gtt_ioctl+0x16d/0x240 [i915]
> [<f82ae786>] ? i915_gem_madvise_ioctl+0x86/0x120 [i915]
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Reported-by: maciej.rutecki at gmail.com
> Cc: stable at kernel.org

Tricky.  Looks like a good fix.  Applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100317/9498286b/attachment.sig>


More information about the Intel-gfx mailing list