[Intel-gfx] [PATCH 0/2] introduce derefenrencing helpers

[Eric Anholt]

On Mon,  8 Mar 2010 13:35:01 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Hi Eric,
> 
> These two patches introduce access helpers for the bo and device private
> structures. I've done the helper for the gem objects because I want to
> fiddle around in that area (e.g. make drm_gem_object subclass-able). This
> is way easier when the access is nicely hidden.
> 
> While doing such utter boring stuff, I've also put the device private
> structure to the same treatment. Might be useful in the future.
> 
> I hope right after the merge window is the best time to push such stuff,
> when everyone has flushed their patch-queues.
> 
> Now functional changes in here whatsoever.
> 
> Please review and merge for .34. The patches apply against latest
> drm-intel-next.
> 
> Thanks, Daniel
> 
> Daniel Vetter (2):
>   drm/i915: introduce to_intel_bo helper
>   drm/i915: introduce to_intel_dev helper

Informal review on IRC was "wow, that's a lot of churn.  Does it do
something useful?"

Certainly the dev_priv one makes the intel driver look different from
all other drivers, and I don't think in a good way.  If we had a record
of getting types mixed up, the type safety might make a good argument,
but when you just copy and paste the line for the lookup every time
anyway...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100317/7db78b11/attachment.sig>