[Intel-gfx] [PATCH] Use ALIGN macro instead of open coding it.

[Carl Worth]

On Fri, 12 Mar 2010 00:30:23 -0500, Matt Turner <mattst88 at gmail.com> wrote:
> Also, kill off ROUND_TO, ROUND_DOWN, ROUND_TO_PAGE, and ROUND_TO_MB
> macros. ROUND_{TO,DOWN} are only useful if rounding to a non-power of
> two, which they always were, and ROUND_TO_PAGE and ROUND_TO_MB
> inherently round to a power of two, so just use ALIGN.

I see you've followed this patch up with an improved version in a later
thread.

For me, I would prefer if updates to a patch would be sent as replies to
the original patch. That helps me avoid merging the old patch without
realizing it, (while processing my patch queue in chronological order).

Thanks!

-Carl

PS. Your commit message includes:

> Also, kill off i830_pad_drawable_width.

That word "also" is a red flag for me. It suggests an independent
change, and independent changes should almost always be in separate
commits. I don't know how many times I've bisected a bug down to an
excessively large commit with the word "also" in it.

Similarly, I do know that when I've gone through the process of
separating multiple intertwined changes to create a clean series of
minimal commits, that I've often improved the commits and fixed bugs
that I hadn't noticed when things were intertwined. Tiny, independent
commits help the original author just as much as they help reviewers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100318/544483c2/attachment.sig>