[Intel-gfx] [PATCH] Use ALIGN macro instead of open coding it.

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 18 18:06:06 CET 2010


On Thu, 18 Mar 2010 12:56:13 -0400, Matt Turner <mattst88 at gmail.com> wrote:
> I think if you check out the patch, you won't see anything wrong with
> removing that function. It was just an ALIGN(..., 64) so it seemed
> sensible to get rid of it by replacing calls to it with ALIGN(..., 64)
> given the purpose of the patch.

The argument would be then to encapsulate that as an inline:
  static inline int i830_pitch_align(int bytes) { return ALIGN(bytes, 64); }
and then we can debate whether that should be just 32 instead.
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list