[Intel-gfx] [PATCH 0/9] split intel-agp.c into gtt and agp port driver

Daniel Vetter daniel.vetter at ffwll.ch
Fri Mar 19 21:46:22 CET 2010


Hi all,

This is my first pile of patches to clean up the intel_agp module. The main
problem is that this modules contains two drivers: One for the old (mainly
i8xx series) agp port, one for the gtt needed by all intel onboard graphic
chips (by the drm module). This results in needlessly confusing code.
Therefore split this into two parts: intel-gtt.c and intel-agp-gart.c

I've also included two small cleanups for intel-ggt.c as the last two
patches in this series. But there's enough stuff for more patches: I've
seen some rather gross amounts of code-duplication between intel-agp.c and
i915_dma.c from the i915 drm module.

Because we can't get rid of the gtt driver in the intel_agp module for now
(breaks the non-gem drm usespace abi) my plan is to introduce a common
header for intel gtt handling. This way the drm module could directly call
functions in intel_agp. Comments and ideas highly welcome.

Please review and merge for .35.

Thanks, Daniel

Daniel Vetter (9):
  agp/intel: intel_845_driver is an agp driver!
  agp/intel: introduce intel-agp.h header file
  agp/intel: split out the GTT support
  agp/intel: uncoditionally reconfigure driver on resume
  drm/intel: kill mutli_gmch_chip
  agp/intel: split out gmch/gtt probe, part 1
  agp/intel: split out gmch/gtt probe, part 2
  agp/intel-gtt: kill intel_i830_tlbflush
  agp/intel-gtt: kill previous_size assignments

 drivers/char/agp/Makefile         |    1 +
 drivers/char/agp/agp.h            |   80 --
 drivers/char/agp/efficeon-agp.c   |    1 +
 drivers/char/agp/intel-agp-gart.c |  925 +++++++++++++
 drivers/char/agp/intel-agp.c      | 2705 -------------------------------------
 drivers/char/agp/intel-agp.h      |  237 ++++
 drivers/char/agp/intel-gtt.c      | 1617 ++++++++++++++++++++++
 7 files changed, 2781 insertions(+), 2785 deletions(-)
 create mode 100644 drivers/char/agp/intel-agp-gart.c
 delete mode 100644 drivers/char/agp/intel-agp.c
 create mode 100644 drivers/char/agp/intel-agp.h
 create mode 100644 drivers/char/agp/intel-gtt.c




More information about the Intel-gfx mailing list