[Intel-gfx] [PATCH] drm/i915: Fix the incorrect argument for SDVO SET_TV_format command

Zhenyu Wang zhenyuw at linux.intel.com
Tue Mar 23 03:58:06 CET 2010


On 2010.03.11 10:17:16 +0800, Zhenyu Wang wrote:
> From: Zhao Yakui <yakui.zhao at intel.com>
> 
> Otherwise it will cause that S-video output becomes black/white when switching
> to other TV format.
> 
> http://bugs.freedesktop.org/show_bug.cgi?id=23916
> 
> Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> Tested-by: Arnold <arnold.erbsloeh at web.de>
> Tested-by: Bazin <bazin.cz at gmail.com>
> Tested-by: Nigel <nigel_tuck at eircom.net>
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> ---
> 
> This depends on previous SDVO rework patch, so we don't cc kernel stable for
> this one. Backport needs to be done for .32 and .33 stable.
> 
>  drivers/gpu/drm/i915/intel_sdvo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 7ce369a..cf9529e 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -1095,7 +1095,7 @@ static void intel_sdvo_set_tv_format(struct intel_encoder *intel_encoder)
>  	memcpy(&format, &format_map, sizeof(format_map) > sizeof(format) ?
>  			sizeof(format) : sizeof(format_map));
>  
> -	intel_sdvo_write_cmd(intel_encoder, SDVO_CMD_SET_TV_FORMAT, &format_map,
> +	intel_sdvo_write_cmd(intel_encoder, SDVO_CMD_SET_TV_FORMAT, &format,
>  			     sizeof(format));
>  
>  	status = intel_sdvo_read_response(intel_encoder, NULL, 0);
> -- 

Eric, how about this one?

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100323/1c8ef9da/attachment.sig>


More information about the Intel-gfx mailing list