[Intel-gfx] [PATCH 0/2] introduce derefenrencing helpers

[Eric Anholt]

On Thu, 18 Mar 2010 09:34:33 +1000, Dave Airlie <airlied at gmail.com> wrote:
> On Thu, Mar 18, 2010 at 7:45 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Wed, Mar 17, 2010 at 02:15:26PM -0700, Eric Anholt wrote:
> >> On Mon,  8 Mar 2010 13:35:01 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> >> Informal review on IRC was "wow, that's a lot of churn.  Does it do
> >> something useful?"
> >>
> >> Certainly the dev_priv one makes the intel driver look different from
> >> all other drivers, and I don't think in a good way.  If we had a record
> >> of getting types mixed up, the type safety might make a good argument,
> >> but when you just copy and paste the line for the lookup every time
> >> anyway...
> >
> > Well, type-safety was not the goal of these ... I've intended to make
> > drm_gem_object subclassable (i.e. obj_priv.base instead of obj_priv->obj).
> 
> 
> I'd like to subscribe to your newsletter.
> 
> I meant to do this back at the start of GEM and I really wished I'd
> one it then, so
> its a Yay from me.

OK.  I've gone ahead and applied the GEM one.  If the dev_priv one is
going to happen, I'd rather see the whole DRM whacked at once so we have
a consistent style there.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100324/d6a71a09/attachment.sig>