[Intel-gfx] [PATCH] drm/i915/gen4: Extra CRT hotplug paranoia

[Adam Jackson]

On Mon, 2010-05-24 at 21:46 -0400, Andrew Lutomirski wrote:
> On Mon, May 24, 2010 at 4:46 PM, Adam Jackson <ajax at redhat.com> wrote:
> > Disable the CRT plug interrupt while doing the force cycle, explicitly
> > clear any CRT interrupt we may have generated, and restore when done.
> > Should mitigate interrupt storms from hotplug detection.
> >
> 
> Is there any locking in here to protect PORT_HOTPLUG_EN?  I'm asking
> because I *still* can't use mainline kernels reliably without
> commenting out digital output initialization, and that's one place
> where a bug might be lurking.

At least in d-i-n, PORT_HOTPLUG_EN is only ever written to from ->detect
in the connector vtable, and from IRQ setup.  I don't have a firm
understanding of the locking around either path, but I'd be rather
surprised if it was racy in any practical sense, since neither of those
should get called from interrupt context and you typically only have one
app doing setup.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100525/d3813e00/attachment.sig>