[Intel-gfx] [PATCH] drm/i915: Kill dangerous pending-flip debugging

[Eric Anholt]

On Sat, 15 May 2010 09:31:17 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Sat, 15 May 2010 09:57:03 +0100
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> 
> > We can, by virtue of a vblank interrupt firing in the middle of
> > setting up the unpin work (i.e. after we set the unpin_work field and
> > before we write to the ringbuffer) enter intel_finish_page_flip()
> > prior to receiving the pending flip notification. Therefore we can
> > expect to hit intel_finish_page_flip() under normal circumstances
> > without a pending flip and even without installing the
> > pending_flip_obj. This is exacerbated by aperture thrashing whilst
> > binding the framebuffer
> > 
> > References:
> > 
> >   Bug 28079 - "glresize" causes kernel panic in
> > intel_finish_page_flip.
> > https://bugs.freedesktop.org/show_bug.cgi?id=28079
> 
> Yeah, that's true.  Good catch.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Applied.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100526/81e3a8f9/attachment.sig>