[Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

Chris Wilson chris at chris-wilson.co.uk
Fri May 28 11:36:55 CEST 2010


On Fri, 28 May 2010 11:28:50 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote:
> > Since we now get_user_pages() outside of the mutex prior to performing
> > the copy, we kmap() the page inside the copy routine and so need to
> > perform an ordinary memcpy() and not copy_from_user().
> 
> Patches look sane and will definitely help in (someday) fixing up the racy
> pwrite/pread locking.

Now who's being optimistic... ;-)

All I am trying to do is find some way to explain
  https://bugs.freedesktop.org/show_bug.cgi?id=26645#c5
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list