[Intel-gfx] [PATCH] drm/i915: use wake_up instead of drm wrapper.

[Jesse Barnes]

On Fri, 28 May 2010 19:55:24 +1000
Dave Airlie <airlied at gmail.com> wrote:

> On Fri, May 28, 2010 at 7:12 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Fri, May 28, 2010 at 01:02:08PM +1000, Dave Airlie wrote:
> >> This fixes a regression in the copy fb code we use to get seamless
> >> startup on Fedora/RHEL, without this fix, we block forever in the wait
> >> when starting X.
> >
> > I've just checked latest -linus and found in include/drm/drm_os_linux.h:
> >
> > #define DRM_WAKEUP( queue ) wake_up( queue )
> >
> > It's been like that since I've originally wrote the uninterruptible sleep
> > stuff for the intel overlay code (I've checked way back then to make sure
> > it doesn't hang). Care to explain how this fixes a regression?
> >
> 
> doh, you fixed that in the patch, and for some reason we don't have
> that in our Fedora or RHEL backports wierd.
> 
> Ignore this.
> 
> I don't remember much discussion on changing drm_os_linux, but it
> should have been fine.

We should still kill the drm_os_linux bits where possible...

-- 
Jesse Barnes, Intel Open Source Technology Center