[Intel-gfx] [PATCH] drm/i915: remove debug fmax

Jesse Barnes jbarnes at virtuousgeek.org
Mon Nov 1 21:57:02 CET 2010


On Mon, 1 Nov 2010 16:26:05 -0400
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> Accidentally got pushed when we added power monitoring support.  We
> need IPS to modify this value rather than always setting it to the
> max.
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 4954af2..688b51d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5588,7 +5588,6 @@ void ironlake_enable_drps(struct drm_device
> *dev) fmin = (rgvmodectl & MEMMODE_FMIN_MASK);
>  	fstart = (rgvmodectl & MEMMODE_FSTART_MASK) >>
>  		MEMMODE_FSTART_SHIFT;
> -	fstart = fmax;
>  
>  	vstart = (I915_READ(PXVFREQ_BASE + (fstart * 4)) &
> PXVFREQ_PX_MASK) >> PXVFREQ_PX_SHIFT;

This is necessary but not sufficient.  We also need to clamp the
initial max_delay at fstart and leave fmax alone (patch from Eric on
its way).

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list