[Intel-gfx] [PATCH] drm/i915: Fix the graphics frequency clamping at init and when IPS is active.

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 2 10:37:35 CET 2010


On Mon,  1 Nov 2010 14:12:01 -0700, Eric Anholt <eric at anholt.net> wrote:
> From: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> Part of the issue here was that Eric slipped in a debug hack for
> testing the i915 IPS code before the intel_ips.c driver had landed.
> This caused the driver to always use the full range of frequencies,
> which is only legal when IPS tells us we have the headroom.  Once that
> hack was removed, there was confusion about the driver's frequency
> clamping variables: max_delay is the driver's current limit on the
> highest frequency the IPS driver wants us to use, while dev_priv->fmax
> is the hardware-reported limit that the IPS driver can increase up to.

Dropped the promotion to DRM_ERROR and applied to -fixes. Since your
changelog says that what we have right now is programming invalid values
into the IPS, I've marked it for stable.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list