[Intel-gfx] [PATCH] Disable frame buffer compression on ironlake

[Jesse Barnes]

On Fri, 19 Nov 2010 08:47:27 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Fri, 19 Nov 2010 10:00:03 +0800, "Alex,Shi" <alex.shi at intel.com> wrote:
> >  Open fbc will cause about 1 Watts power increase on ironlake
> >  for bltk-office/player benchmark. So just disable it and left
> >  code here to waiting for better solution.
> 
> FBC is disabled through the chicken bits, so I am really curious to know
> where the power saving is coming from. I just want to verify that we have
> not made a fundamental mistake in our FBC logic that is consuming more
> power than is necessary across all platforms.
> 
> In terms of code clarity, we should leave a note as to why we explicitly
> disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */

Did we disable the whole thing with chicken bits?  I thought we only
disabled some aspects of FBC that were known buggy.  AFAIK it should
generally work on ILK.  You can assign the bug to me, I'll take a look.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center