[Intel-gfx] [PATCH] drm/i915/sdvo: Only enable HDMI encodings only if the commandset is supported

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 22 14:31:03 CET 2010


On Mon, 22 Nov 2010 13:16:43 +0000, Simon Farnsworth <simon.farnsworth at onelan.co.uk> wrote:
> On Monday 22 November 2010, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > As we conflated intel_sdvo->is_hdmi with both having HDMI support on the
> > ADD along with having HDMI support on the monitor, we would attempt to
> > use HDMI encodings even if the interface did not support those commands.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> This fixes my problems with the image being in the middle third or so of the 
> screen. I've also read the patch and resulting state of code, and it looks 
> like the right thing to do, so take your pick of:
> 
> Tested-by: Simon Farnsworth <simon.farnsworth at onelan.co.uk>
> Reviewed-by: Simon Farnsworth <simon.farnsworth at onelan.co.uk>

Excellent! Pushed to -fixes.

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list