[Intel-gfx] [PATCH] drm/i915: new blitter ring support from Sandybridge

[Chris Wilson]

On Tue, 12 Oct 2010 16:13:51 +0800, Zhenyu Wang <zhenyuw at linux.intel.com> wrote:
> This adds new ring for blitter engine starting from Sandybridge.

Thanks, look fairly straightforward. The messy parts are a clear reminder
that I intended to clean up some areas for multiple rings.

* bikeshedding

s/HAS_BLIT_SPLIT/HAS_BLT/ -- the documentation has ingrained BLT engine
into my head (and I hope they haven't changed on a whim for snb)

After initialisation we should not need to care about HAS_BSD/HAS_BLT and
just test whether the ring is initialised or active (depending upon op).
That should dramatically reduce the number of tests in our code and
hopefully lead to further simplifications.

Unified request list (along with per-ring lists) will sort out the mess in
i915_gem_evict and also solve the wrap-around issue.

So no get/put irq again?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre