[Intel-gfx] [PATCH] i915: enable AVI infoframe for intel_hdmi.c [v2]
David Härdeman
david at hardeman.nu
Fri Sep 10 10:13:15 CEST 2010
On Thu, September 9, 2010 23:58, Chris Wilson wrote:
> On Thu, 09 Sep 2010 23:00:01 +0200, David Härdeman <david at hardeman.nu>
> wrote:
>> This is the second version which merges the infoframe code from
>> intel_hdmi.c and intel_sdvo.c, I hope this is something along the lines
>> Chris Wilson had in mind. Note that I'm assuming that the sdvo hardware
>> also stores a header ECC byte in the MSB of the first dword (haven't
>> found
>> any documentation for the sdvo).
>
> Pretty close. Using a callback function for writing the data is overkill,
> just call the common function to compute the avi csum, then pass the avi
> to the sdvo or hdmi handlers. It just makes following the logic that
> little bit easier.
>
> drm-intel-next has changed slightly since you wrote the patch, so can you
> respin it - just a couple of the macro names have changed to be
> consistent.
I'll respin the patch, but I still need to know if the intel_sdvo.c
hardware has an ECC byte as the MSB of the first dword or not.
--
David Härdeman
More information about the Intel-gfx
mailing list