[Intel-gfx] [PATCH v3] CHROMIUM: i915: Added function to initialize VBT settings

[Paul Menzel]

Am Mittwoch, den 29.09.2010, 10:34 +0100 schrieb Chris Wilson:
> On Tue, 28 Sep 2010 16:12:16 -0700, Simon Que <sque at chromium.org> wrote:
> > Hi all,
> > 
> > I have updated the patch containing the dither bit change and VBT
> > default settings.  This time, all default values have been moved to a
> > single function, init_vbt_defaults.  This function is called from
> > intel_init_bios before checking for VBT.  Hence, it is used in both
> > the VBT found and VBT not found cases.
> > 
> > The parse functions previously contained VBT default values for the
> > case where VBT was found -- those have been moved to the new function
> > init_vbt_defaults.  This new arrangement reduces code redundancy (no
> > need to set dither bit in two places) and consolidates all default
> > settings into one place.
> 
> Looks very good. Just one minor niggle... It makes life much easier if
> the patch is in a format digestible by git am.

Christ, Simon attached the patch too.

Simon, I think you can sent the patch inline with your message in the
beginng by using a scissors line.

    $ git help mailinfo
    […]
       --scissors
           Remove everything in body before a scissors line. A line that
           mainly consists of scissors (either ">8" or "8<") and perforation
           (dash "-") marks is called a scissors line, and is used to request
           the reader to cut the message at that line. If such a line appears
           in the body of the message before the patch, everything before it
           (including the scissors line itself) is ignored when this option is
           used.

           This is useful if you want to begin your message in a discussion
           thread with comments and suggestions on the message you are
           responding to, and to conclude it with a patch submission,
           separating the discussion and the beginning of the proposed commit
           log message with a scissors line.

           This can enabled by default with the configuration option
           mailinfo.scissors.

       --no-scissors
           Ignore scissors lines. Useful for overriding mailinfo.scissors
           settings.
    […]

And Chris can use `git am -c …` to apply the patch (`git help am`).

[…]


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100929/7cca2ea8/attachment.sig>