[Intel-gfx] [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes

[Keith Packard]

On Tue,  5 Apr 2011 10:24:14 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

>  	crtc = intel_get_crtc_for_plane(dev, plane);
> -	if (crtc->fb == NULL || !crtc->enabled)
> +	if (crtc->fb == NULL || !crtc->enabled) {
> +		*cursor_wm = *plane_wm = display->guard_size;
>  		return false;
> +	}

Would it be clearer to have g4x_update_wm set these instead?

I'm also a bit concerned about the default value; it would be lovely to
have the docs say what the value should be for disabled pipes, but I
couldn't find any mention of them.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110405/22a3b15f/attachment.sig>