[Intel-gfx] [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes

[Keith Packard]

On Tue, 05 Apr 2011 22:12:19 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

> Indeed, I started by setting them to zero in the caller. Decided that
> there was some precedent to use the guard_size as the minimum value for
> unused planes (and so perhaps the unused planes on the unused pipes) and
> so it was then natural to do it inside g4x_compute_wm. I guess it all
> depends on how many FIFOs are split between the pipes. Using guard_size,
> I believe, should be safest.

guard_size is probably better than random stack stuff. Any opinion on
whether this should be done in g4x_update_wm instead of g4x_compute_wm0?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110405/725d56a1/attachment.sig>