[Intel-gfx] [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes

[Keith Packard]

On Wed, 06 Apr 2011 07:59:37 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

> I'd prefer to keep the mucking around with intel_watermak_params in the
> one spot. How about:

My concern is that g4x_compute_wm0 is now different from
ironlake_compute_wm0, which seems like a potential trap for the
unwary.

> -	*plane_wm = entries + display->guard_size;
> +	*plane_wm += entries;
...
> -	*cursor_wm = entries + cursor->guard_size;
> +	*cursor_wm += entries;

Uh, no. If we find out that '0' is the right value for the off-case, I
don't want to discover that we forgot to reset these...

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110406/4b90608b/attachment.sig>