[Intel-gfx] [PATCH 27/30] drm/i915: Invalidate fenced read domains upon flush

Daniel Vetter daniel at ffwll.ch
Wed Apr 13 21:43:59 CEST 2011


On Tue, Apr 12, 2011 at 09:31:55PM +0100, Chris Wilson wrote:
> Whenever we finish reading an object through a fence, for safety we
> clear any GPU read domain and so invalidate any TLBs associated with
> the fenced region upon its next use.

Now that flush_fence ensures that we are paranoid and flush/invalidate
caches the 
	if (fenced_gpu_access && !pending_fenced_gpu_access)
		flush_some_more();
code is indeed superfluous. But please explain that in the changelog, it has
taken me a while to (re-)figure out while the second hunk is correct.

Otherwise
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
still stands.
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list