[Intel-gfx] [PATCH 2/3] drm/i915: reference counted forcewake

[Chris Wilson]

On Mon, 18 Apr 2011 10:31:43 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> I'll split the patches. I can also use the awake() variant for the
> existing users, if you're okay with the awake() function (I was actually
> expecting a comment from you on that). For the relevant functions, it
> should be as simple as:
> s/I915_READ32/i915_read32_awake
> s/__gen6_gt_force_wake_/gen6_gt_force_wake_/

I did see the interface and also noted the absence of users... I'd like to
see the patches to convert the current long sequences structured in such
a way as to not break the current assumption that rc6 doesn't trigger
in the middle.
 
> Jesse has started the email to verify IIR is in fact a problem for us.
> So I'll postpone resubmitting the patches until that's confirmed.

That will be a relief and offer some simplifications no doubt...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre