[Intel-gfx] [PATCH 07/17] drm/i915: Only enable the plane after setting the fb base (pre-ILK)

Jesse Barnes jbarnes at virtuousgeek.org
Fri Apr 22 00:27:21 CEST 2011


On Thu, 21 Apr 2011 22:18:22 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> When enabling the plane, it is helpful to have already pointed that
> plane to valid memory or else we may incur the wrath of a PGTBL_ER.
> This code preserved the behaviour from the bad old days for unknown
> reasons...
> 
> Found by assert_fb_bound_for_plane().
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=36246
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

(needs lots of testing on 8xx, 9xx and 965 I think)

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list