[Intel-gfx] [PATCH 04/16] drm/i915: add Ivy Bridge PCI IDs and flags

[Chris Wilson]

On Wed, 27 Apr 2011 14:01:50 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Wed, 27 Apr 2011 07:59:17 +0100
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > So I think we just want IS_GEN7() for IVB code.
> 
> I'd rather keep them separate since we know we'll have gen7 chips with
> different display engines in the future.  I've been trying to use
> IS_GEN for render related checks, IS_IVB for specific display checks,
> and HAS_PCH for the ilk+ split (though for the most part that should go
> away with proper function call backs).

If there is method to the madness, fine. I like the explanation and so
perhaps we should include that in the code somewhere. And we just need to
make sure we are consistent in our usage.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre