[Intel-gfx] [PATCH 08/19] drm/i915: manual FDI training for Ivy Bridge

[Jesse Barnes]

On Thu, 28 Apr 2011 15:43:10 -0700
Keith Packard <keithp at keithp.com> wrote:

> On Thu, 28 Apr 2011 15:12:54 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> 
> > +	if (IS_GEN6(dev)) {
> > +		temp &= ~FDI_LINK_TRAIN_NONE;
> > +		temp |= FDI_LINK_TRAIN_NONE | FDI_TX_ENHANCE_FRAME_ENABLE;
> > +	} else if (IS_IVYBRIDGE(dev)) {
> > +		temp &= ~FDI_LINK_TRAIN_NONE_IVB;
> > +		temp |= FDI_LINK_TRAIN_NONE_IVB | FDI_TX_ENHANCE_FRAME_ENABLE;
> > +	}
> 
> This seems inconsistent using IS_GEN6 for SNB and IS_IVYBRIDGE for IVB?

Yes, there are several IS_GEN checks that I'd argue are wrong, I can
clean them up in a subsequent.

-- 
Jesse Barnes, Intel Open Source Technology Center