[Intel-gfx] [PATCH] drm/i915: limit PM related interrupt enable to those we handle

[Keith Packard]

On Tue,  9 Aug 2011 09:29:20 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> -	I915_WRITE(GEN6_PMIMR, 0);
> +	I915_WRITE(GEN6_PMIMR, ~GEN6_PM_DEFERRED_EVENTS);
>  	spin_unlock_irq(&dev_priv->rps_lock);
> -	/* enable all PM interrupts */
> -	I915_WRITE(GEN6_PMINTRMSK, 0);
> +	/* Enable only those we respond to in the deferred work handler */
> +	I915_WRITE(GEN6_PMINTRMSK, GEN6_PMINTR_DEFERRED_EVENTS);

I think this is supposed to only enable the DEFERRED_EVENTS, right? In
which case, I think you want to invert that (as 0 enables and 1 disables):

 +	I915_WRITE(GEN6_PMINTRMSK, ~GEN6_PMINTR_DEFERRED_EVENTS);

just like you did for the PMIMR register?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110809/4ebfdd9f/attachment.sig>