[Intel-gfx] [intel-gfx][intel-gpu-tools][patch] Review of some patches to get rid of some compile warnings

Diego Celix dcelix at gmail.com
Wed Feb 9 19:00:34 CET 2011


Hello,


I've been doing some little modifications of the code of the intel-gpu-tools
package to get the compile warnings fixed. I've divided those changes in
little commits.

The 0001 patch file fixes these warnings:
intel_disable_clock_gating.c:38: warning: unused variable 'temp'
intel_bios_reader.c:192: warning: format '%lu' expects type 'long unsigned
int', but argument 2 has type 'unsigned int'

The next patches corrects almost the same things.
The 0002 patch file, fixes these warnings:
intel_error_decode.c:374: warning: ignoring return value of 'asprintf',
declared with attribute warn_unused_result
intel_error_decode.c:380: warning: ignoring return value of 'asprintf',
declared with attribute warn_unused_result

The 0003 patch file fixes these warnings:
intel_gpu_dump.c:308: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result
intel_gpu_dump.c:357: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result
intel_gpu_dump.c:362: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result
intel_gpu_dump.c:370: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result
intel_gpu_dump.c:375: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result
intel_gpu_dump.c:382: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result
intel_gpu_dump.c:387: warning: ignoring return value of 'asprintf', declared
with attribute warn_unused_result

The 0004 patch file fixes this warning:
intel_reg_snapshot.c:45: warning: ignoring return value of 'write', declared
with attribute warn_unused_result

The 0005 patch file fixes a lot of warnings on intel_reg_dumper, all of them
because of the asprintf fucntion

And finally, the 0006 patch file fixes the overwrite of the result value on
that function, and also a couple of asprintf warnings


I hope it can be useful

--
Diego Celix Salgado
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Some-warning-fixes.patch
Type: text/x-patch
Size: 1233 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-intel_error_decode-asprintf-warning-fix.patch
Type: text/x-patch
Size: 1479 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-intel_gpu_dump-asprintf-warning-fix.patch
Type: text/x-patch
Size: 3481 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-intel_reg_snapshot-Warning-fix.patch
Type: text/x-patch
Size: 892 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-intel_reg_dumper-asprintf-warning-fix.patch
Type: text/x-patch
Size: 28599 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-intel_reg_dumper-if-else-fix-in-i830_debug_fp-funcio.patch
Type: text/x-patch
Size: 1698 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110209/24d2ce49/attachment-0005.bin>


More information about the Intel-gfx mailing list