[Intel-gfx] [intel-gpu-tools] intel_audio_dump problem with GEN5 devices

Diego Celix dcelix at gmail.com
Tue Feb 15 18:41:20 CET 2011


Hi!,

When I run the intel_audio_dump tool with my laptop (Core i5 Intel HD
Graphics) seems that it is not correctly fetching the data.

This is a piece of the source, in which the HAS_PCH_SPLIT macro is
called (Line 1197, intel_audio_dump.c)

        if (HAS_PCH_SPLIT(devid) || getenv("HAS_PCH_SPLIT")) {
                intel_check_pch();
                dump_cpt();
        } else if (IS_GEN5(devid))
                dump_ironlake();
        else
                dump_eaglelake();


In the HAS_PCH_SPLIT macro is also checked if the device is GEN5, so
in my case, I will never reach the second statement.
I've checked the output of the dump_ironlake() function, and seems to be ok.

As in other files the HAS_PCH_SPLIT macro is used, I'm not pretty sure
about the best solution here.
I simply checked if it is a GEN6 device instead of using the
HAS_PCH_SPLIT macro.

I have attached the change I made.


Regards,

-- 
Diego Celix
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-intel_audio_dump-Removed-repeated-check-for-GEN5.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110215/9e58ad02/attachment.bin>


More information about the Intel-gfx mailing list