[Intel-gfx] [PATCH] intel: Add AUB file dump support

[Kenneth Graunke]

On Tuesday, February 22, 2011 05:49:57 PM Zhenyu Wang wrote:
[snip]
> > We also can't commit code to Mesa that just writes into some arbitrary
> > file based on an environment variable -- keep in mind that our Mesa
> > driver is loaded from the X Server which is running as root.
> 
> yeah, I wasn't aware of this, any comment for how to dump the file?

We could simply not commit this patch to master, but keep it in a branch and 
apply it when we need AUB file dumping support.

Alternatively, perhaps we could commit everything, but change patch 1/3 to:
#if 0
{ "aub", DEBUG_AUB },
#endif

This makes it ridiculously easy for us to enable INTEL_DEBUG=aub, but doesn't 
ship the potential security exploit.  Also, since a .c file would have to be 
changed, it's unlikely a distributor would accidentally enable it.

Thoughts?