[Intel-gfx] [PATCH 5/5] xvmc: Stop using uninitialized variable.

Cyril Brulebois kibi at debian.org
Mon Jan 31 06:22:39 CET 2011


The actual code was removed in 5f64122551, where the get_surface_status
driver callback was dropped. Just return Success if there were no issues
with the parameter.

Get rid of the following with CFLAGS="-Wall -Werror":
|   CC     intel_xvmc.lo
| cc1: warnings being treated as errors
| intel_xvmc.c: In function ‘XvMCSyncSurface’:
| intel_xvmc.c:677: error: ‘ret’ may be used uninitialized in this function
| intel_xvmc.c:672: note: ‘ret’ was declared here

Signed-off-by: Cyril Brulebois <kibi at debian.org>
---
 src/xvmc/intel_xvmc.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/xvmc/intel_xvmc.c b/src/xvmc/intel_xvmc.c
index d89cda2..1b96945 100644
--- a/src/xvmc/intel_xvmc.c
+++ b/src/xvmc/intel_xvmc.c
@@ -669,12 +669,10 @@ _X_EXPORT Status XvMCPutSurface(Display * display, XvMCSurface * surface,
  */
 _X_EXPORT Status XvMCSyncSurface(Display * display, XvMCSurface * surface)
 {
-	Status ret;
-
 	if (!display || !surface)
 		return XvMCBadSurface;
 
-	return ret;
+	return Success;
 }
 
 /*
-- 
1.7.2.3




More information about the Intel-gfx mailing list