[Intel-gfx] [PATCH 5/6] drm/i915: Only export the generic intel_disable_fbc() interface

Jesse Barnes jbarnes at virtuousgeek.org
Thu Jul 7 18:16:59 CEST 2011


On Thu,  7 Jul 2011 12:48:10 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> As the enable/disable routines will be gain additional complexity in
> future patches, it is necessary that all callers do not bypass the
> generic interface by calling into the chipset routines directly. to do
> this we make the chipset routines static, so there is no choice.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_dma.c      |    4 ++-
>  drivers/gpu/drm/i915/i915_drv.h      |    6 +---
>  drivers/gpu/drm/i915/i915_suspend.c  |    4 +--
>  drivers/gpu/drm/i915/intel_display.c |   50 +++++++++++++++++-----------------
>  4 files changed, 30 insertions(+), 34 deletions(-)
> 

The code motion made me look twice, but it's a real fix.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list