[Intel-gfx] [PATCH] drm/i915: Share the common work of disabling active FBC before updating

[Keith Packard]

On Thu,  7 Jul 2011 22:14:18 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Upon review, all path share the same dependencies for updating the
> registers and so we can benefit from sharing the code and checking
> early.
> 
> This removes the unsightly intel_wait_for_vblank() from the lowlevel
> functions and upon further analysis the only path that will require a
> wait is if we are performing an instantaneous transition between two
> valid FBC configurations. The page-flip path itself will have disabled
> FBC registers and will have waited for at least one vblank before
> finishing the flip and attempting to re-enable FBC.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
> 
> Respun without the blocking wait. Noting instead that since we delay
> enabling FBC by 50ms we can assume that a vblank passes after disabling
> FBC and before modifying the control registers.
> -Chris

Looks good to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110707/f585260c/attachment.sig>