[Intel-gfx] [PATCH] drm/i915: Skip GPU wait for scanout pin while wedged

[Keith Packard]

On Wed, 20 Jul 2011 01:03:17 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

> This doesn't prevent us returning an error should the wait-rendering abort
> due to a GPU hang occurring in the middle of the wait.

Yeah, should probably check the return value and ignore the error instead.

> i915_gem_object_pin_to_display_plane is used for more than just the
> scanout, cursors and overlay are also included, otherwise we could just
> ignore any errors. So,

Given that the GPU is wedged, I don't see any problem pinning any of
these instead of failing.

> /* Update the display engine regardless of any GPU hangs */
> if (ret == -ERESTARTSYS)
> 	return ret;

Yeah, that seems simpler in all ways. Much nicer.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110719/01d35f5d/attachment.sig>