[Intel-gfx] [PATCH] drm/i915: apply phase pointer override on SNB+ too

Keith Packard keithp at keithp.com
Fri Jul 29 20:47:55 CEST 2011


On Fri, 29 Jul 2011 10:50:11 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> +	flags |= FDI_PHASE_SYNC_OVR(pipe);
> +	I915_WRITE(SOUTH_CHICKEN1, flags); /* once to unlock... */
> +	flags |= FDI_PHASE_SYNC_EN(pipe);
> +	I915_WRITE(SOUTH_CHICKEN1, flags); /* then again to enable */
> +	POSTING_READ(SOUTH_CHICKEN1);
> +}

ooh, this even makes the sequence of two writes sound sensible.

Reviewed-by: Keith Packard <keithp at keithp.com>

You didn't happen to check the register values after doing this, did
you? Just to verify that all of the crazy math works, given that we
can't actually test whether this fixes anything.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110729/8f0aed51/attachment.sig>


More information about the Intel-gfx mailing list