[Intel-gfx] [PATCH fixes] drm/i915: Fix unfenced alignment on pre-G33 hardware

[Keith Packard]

On Mon,  6 Jun 2011 15:18:44 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

>  	case I915_PARAM_HAS_RELAXED_FENCING:
> -		value = 1;
> +		value = 2;

This looks like a change in ABI to me. I think this means you want a new
ioctl so that applications using the existing HAS_RELAXED_FENCING ioctl
and expecting a boolean will continue to work.

>  uint32_t
> -i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj);
> +i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj,
> +				    int tiling_mode);
...
> -				i915_gem_get_unfenced_gtt_alignment(obj);
> +				i915_gem_get_unfenced_gtt_alignment(obj,
> +								    args->tiling_mode);

This combination looks like a simple bug fix -- not using the new tiling
mode when computing the required alignment. Can you separate out this
From the power-of-two change?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110606/b050a1e6/attachment.sig>