[Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

Ben Widawsky ben at bwidawsk.net
Fri Jun 24 17:46:53 CEST 2011


On Fri, Jun 24, 2011 at 12:48:22AM +0100, Chris Wilson wrote:
> On Thu, 23 Jun 2011 15:49:14 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> > Provide a user accessible way to change the hangcheck timer. This is
> > useful mostly for disabling the timer completely (value <= 0).
> 
> Having i915.hangcheck_interval as a read/write module parameter was
> better. :-p
> -Chris

I considered this, but I wasn't sure how to manage the sysfs parameters,
and prevent users from doing stupid things. Furthermore, I think to be
correct we must delete sync the timer if the user requests an interval
of 0, and we can only do that if we have struct mutex (again the sysfs
problem).

Ben



More information about the Intel-gfx mailing list