[Intel-gfx] Recent changes

[Chris Wilson]

On Tue, 28 Jun 2011 12:36:04 +0300, Konstantin Belousov <kostikbel at gmail.com> wrote:
> I have two questions about recent changes made to the kernel driver:
> 
> 1. Looking at the intel_setup_overlay() after the commit
> ecbec53b1d00ba582f71b210ed96cafc05ebd189, it seems there is potential
> double unlock for the struct_mutex in the (unlikely) case when
> intel_overlay_map_regs() failed.

Dan Carpenter pointed out a further mistake in that we weren't handling
the pin count correctly for 945/965/g33.
 
> 2. In i915_wait_request(), after the commit
> 4697995b98417c6da9ab2708a36f5e2bc926c8ac, shouldn't the calls
> 	i915_driver_irq_preinstall(ring->dev);
> 	i915_driver_irq_postinstall(ring->dev);
> be replaced with
> 	ring->dev->driver->irq_preinstall(ring->dev);
> 	ring->dev->driver->irq_postinstall(ring->dev);
> ?

Yes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre