[Intel-gfx] [PATCH] drm/i915/overlay: Fix unpinning along init error paths

[Keith Packard]

On Tue, 28 Jun 2011 11:27:47 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> As pointed out by Dan Carpenter, it was seemingly possible to hit an error
> whilst mapping the buffer for the regs (except the only likely error
> returns should not happen during init) and so leak a pin count on the
> bo. To handle this we would need to reacquire the struct mutex, so for
> simplicity rearrange for the lock to be held for the entire function.
> For extra pedagogy, test that we only call init once.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Keith Packard <keithp at keithp.com>

I'll get this into drm-intel-fixes once I can fast forward and pick up
Hugh's original patch.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110628/59996bc4/attachment.sig>