[Intel-gfx] [PATCH 0/3] [drm/i915] - LVDS mode setting fixes

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 17 15:26:00 CET 2011


On Thu, 17 Mar 2011 08:57:43 -0500 (CDT), Mike Isely <isely at isely.net> wrote:
> This patch series (3 of them) basically implement the same fixes as was 
> previously done for the userspace driver back in 2008.  The fixes are 
> not a direct port; I coded the changes and obviously tested again.  
> This is also why there are 3 patches not 2; the third one is a fix for 
> another problem uncovered while debugging the fixed mode change.

Mike, thanks for the patches!

I think before we proceed, the question I want to ask is whether it is
preferable to add one super LVDS option (i.e. to parse a parameter string
ala intelfb or video=) which we can use to program the panel configuration
data (channels, bit depth, fixed mode, etc) or to add them ad hoc as
individual parameters?

One concern I have is the one Dave raised: we must be careful when
allowing the user to override panel configuration. The ultimate question
being do we trust the hardware configuration data more than the user
cut'n'pasting from a random forum?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list