[Intel-gfx] [PATCH] drm/i915: use i915_enable_rc6 on SNB too

Ben Widawsky ben at bwidawsk.net
Wed Mar 30 23:32:51 CEST 2011


On Wed, Mar 30, 2011 at 02:08:56PM -0700, Jesse Barnes wrote:
> For debug & testing.
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---

>  	I915_WRITE(GEN6_RC_CONTROL,
> -		   GEN6_RC_CTL_RC6p_ENABLE |
> -		   GEN6_RC_CTL_RC6_ENABLE |
> +		   rc6_mask |
>  		   GEN6_RC_CTL_EI_MODE(1) |
>  		   GEN6_RC_CTL_HW_ENABLE);
> 

Do you also need to set GEN6_RC_CTL_RC7_ENABLE if !i915_enable_rc6? I
don't really know how the hardware works, but I had a similar untested
patch except I added that bit in the rc6 disable case.

Otherwise, you can my r-b:
Reviewed-by: Ben Widawsky <ben at bwidawsk.net>




More information about the Intel-gfx mailing list