[Intel-gfx] [PATCH 09/16] drm/i915/gmbus: Reset the controller on initialisation

[Chris Wilson]

On Thu, 12 May 2011 17:41:36 -0700, Keith Packard <keithp at keithp.com> wrote:
> On Thu, 12 May 2011 22:17:17 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> 
> > Toggle the Software Clear Interrupt bit which resets the controller to
> > clear any prior BUS_ERROR condition before we begin to use the
> > controller in earnest.
> 
> Looks reasonable, except for the bad register offsets (see reply to
> previous patch). I fear this code wasn't tested at all; it shouldn't
> have worked.

It has been booting daily on several machines for a month. I agree it
wouldn't have worked, but the since we automatically fallback to GPIO
should it go south, the failures didn't stop the external monitors from
being lit up.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre