[Intel-gfx] [PATCH] Print the pixel clock of each mode.

Paul Menzel paulepanter at users.sourceforge.net
Tue May 31 11:01:26 CEST 2011


Dear Sun,


Am Montag, den 30.05.2011, 23:55 +0800 schrieb yi.sun at intel.com:
> From: Sun Yi <yi.sun at intel.com>

is a Signed-off-by line needed to get your patch accepted? You can add
it automatically passing `-s` to `git commit` or `git format-patch`.

Additionally next time you could add an example output before and after
your change to the commit message.

> ---
>  tests/testdisplay.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index 41a5753..1efc6e5 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -157,7 +157,7 @@ struct connector {
>  
>  static void dump_mode(drmModeModeInfo *mode)
>  {
> -	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
> +	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d\n",
>  	       mode->name,
>  	       mode->vrefresh,
>  	       mode->hdisplay,
> @@ -169,7 +169,8 @@ static void dump_mode(drmModeModeInfo *mode)
>  	       mode->vsync_end,
>  	       mode->vtotal,
>  	       mode->flags,
> -	       mode->type);
> +	       mode->type,
> +	       mode->clock);
>  }
>  
>  static void dump_connectors(void)
> @@ -201,7 +202,7 @@ static void dump_connectors(void)
>  
>  		printf("  modes:\n");
>  		printf("  name refresh (Hz) hdisp hss hse htot vdisp "
> -		       "vss vse vtot flags type\n");
> +		       "vss vse vtot flags type clock\n");
>  		for (j = 0; j < connector->count_modes; j++)
>  			dump_mode(&connector->modes[j]);
>  

Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110531/a26b1cc6/attachment.sig>


More information about the Intel-gfx mailing list