[Intel-gfx] [PATCH 2/2] drm/i915: Remove extraneous MI_BATCHBUFFER_START from the BLT ring.

Daniel Vetter daniel at ffwll.ch
Sun Nov 6 19:03:18 CET 2011


On Sun, Nov 06, 2011 at 09:51:38AM -0800, Kenneth Graunke wrote:
> This looks like it was part of the BLT ring workaround which the prior
> patch removed.  However, this is a separate patch because it changes
> behavior on shipping platforms.

Nope, this should actually be part of your previous patch. ring->private
for the blt ring is only set for this gen6 preproduction-hw w/a, so this
entire if block should go. You're missing a similar if block in the ring
cleanup.

I've posted that patch a few months back, but due to the Giant Whitespace
Patch haven't yet bothered to forward port it ...

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list