[Intel-gfx] [PATCH] drm/i915: add multi-threaded forcewake support

[Jesse Barnes]

On Fri, 18 Nov 2011 14:01:00 -0800
Keith Packard <keithp at keithp.com> wrote:

> On Fri, 18 Nov 2011 11:36:32 -0800, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> 
> > +	while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1))
> 
> You said this should be << 16

No this one should be looking at the bottom bit, so I think it's ok.

> 
> > +	I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<15) | 1);
> 
> and this should be << 16 too

The write needs the mask, and I'm always off by one. :p

> > +			if (I915_READ(ECOBUS) & FORCEWAKE_MT_ENABLE) {
> 
> ECOBUS (0xa180) is zero on my machine, but I need the new functions.
> 
> Removing the ECOBUS check and switching the shifts to 16 makes this work
> on my machine.

Cool, hope it'll help others too.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111118/f864b080/attachment.sig>