[Intel-gfx] [PATCH 1/3] drm/i915: relative_constants_mode race fix

[Keith Packard]

On Sat, 22 Oct 2011 19:41:23 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:

> +		    mode != dev_priv->relative_constants_mode) {
> +			if (INTEL_INFO(dev)->gen < 4)
> +				return -EINVAL;
> +
> +			if (INTEL_INFO(dev)->gen > 5 &&
> +			    mode == I915_EXEC_CONSTANTS_REL_SURFACE)
> +				return -EINVAL;

You need to clean up before returning; you've allocated cliprects and an
exec buffer and also locked the mutex.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111123/5b067917/attachment.sig>