[Intel-gfx] [PATCH 2/2] drm/i915: add debugfs interface to control rc6 and rps

[Chris Wilson]

On Tue, 29 Nov 2011 12:26:23 -0200, Eugeni Dodonov <eugeni at dodonov.net> wrote:
> For the perf counters, I thought on the following flow of execution with
> this patch:
> 1. prev_val=$(cat /sys/kernel/debug/dri/0/i915_enable_rc6)
> 2. echo 0 > /sys/kernel/debug/dri/0/i915_enable_rc6
> 3. do the perf counters aquisition and testing
> 4. echo $(prev_val) > /sys/kernel/debug/dri/0/i915_enable_rc6
> 
> Comments?

debugfs should never be ABI. Development and debug testing is one thing,
but if we are serious about this, we need to start building an acceptable
user interface elsewhere in /sys.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre